davidradl commented on code in PR #25660:
URL: https://github.com/apache/flink/pull/25660#discussion_r1853936771
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManagerImpl.java:
##########
@@ -160,13 +169,37 @@ public Collection<CommittableWithLineage<CommT>>
commit(Committer<CommT> committ
return committed;
}
- Collection<CommitRequestImpl<CommT>> getPendingRequests(boolean
onlyIfFullyReceived) {
+ Collection<CommitRequestImpl<CommT>> getPendingRequests(boolean
assertFull) {
Review Comment:
could the junits cover all the permutations of this stream - so we know
there are no side effects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
