davidradl commented on code in PR #25660:
URL: https://github.com/apache/flink/pull/25660#discussion_r1853930056
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManager.java:
##########
@@ -56,14 +56,20 @@ public interface CheckpointCommittableManager<CommT> {
*/
CommittableSummary<CommT> getSummary(int emittingSubtaskId, int
emittingNumberOfSubtasks);
+ boolean isFinished();
+
+ /**
+ * Returns true if all committables of all upstream subtasks arrived,
which is only guaranteed
+ * to happen if the DOP of the caller is 1.
+ */
+ boolean hasGloballyReceivedAll();
+
/**
* Commits all due committables if all respective committables of the
specific subtask and
* checkpoint have been received.
*
* @param committer used to commit to the external system
* @return successfully committed committables with meta information
- * @throws IOException
Review Comment:
why are these removed, we still throw these exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
