AHeise commented on code in PR #25660:
URL: https://github.com/apache/flink/pull/25660#discussion_r1856337898
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##########
@@ -181,7 +181,7 @@ private void commitAndEmitCheckpoints() throws IOException,
InterruptedException
private void commitAndEmit(CheckpointCommittableManager<CommT>
committableManager)
throws IOException, InterruptedException {
Collection<CommittableWithLineage<CommT>> committed =
committableManager.commit(committer);
Review Comment:
`commit` is unfortunately not side-effect free; we would never proceed with
your proposal. But maybe it should be side-effect free.
However, I'd like to pick that idea up on master and not the backport (this
PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
