AHeise commented on code in PR #25660:
URL: https://github.com/apache/flink/pull/25660#discussion_r1856350005
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManagerImpl.java:
##########
@@ -160,13 +169,37 @@ public Collection<CommittableWithLineage<CommT>>
commit(Committer<CommT> committ
return committed;
}
- Collection<CommitRequestImpl<CommT>> getPendingRequests(boolean
onlyIfFullyReceived) {
+ Collection<CommitRequestImpl<CommT>> getPendingRequests(boolean
assertFull) {
Review Comment:
That's a good idea. However, the next (and last) PR is touching the code
again and removes the flag. It's only here temporarily to cut the PRs smaller.
The next PR removes async retries (which should have never be done) and that
simplifies the invariants significantly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
