dawidwys commented on code in PR #25952:
URL: https://github.com/apache/flink/pull/25952#discussion_r1917011774
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ResolvedCatalogView.java:
##########
@@ -37,10 +40,18 @@ public final class ResolvedCatalogView
private final ResolvedSchema resolvedSchema;
+ private final @Nullable CatalogView resolvedView;
+
public ResolvedCatalogView(CatalogView origin, ResolvedSchema
resolvedSchema) {
+ this(origin, resolvedSchema, null);
+ }
+
+ public ResolvedCatalogView(
+ CatalogView origin, ResolvedSchema resolvedSchema, CatalogView
resolvedView) {
Review Comment:
I am not happy with those changes as well, but I am afraid we do need the
origin.
The issue is the resolution happens also when you do `CREATE VIEW`. What
comes out of it is passed back to `Catalog#createTable`. I am not confident
it's safe to pass something different than the original view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
