snuyanzin commented on code in PR #25952:
URL: https://github.com/apache/flink/pull/25952#discussion_r1915505638
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java:
##########
@@ -177,6 +177,31 @@ void testTimeAttributeOfView() {
+ "GROUP BY window_start, window_end");
}
+ @TestTemplate
+ void testTimeAttributeOfViewSelect() {
+ if (!streamingMode) {
+ // time attributes not supported in batch
+ return;
+ }
+ TableTestUtil testUtil = getTestUtil();
+ TableEnvironment tableEnvironment = testUtil.getTableEnv();
+ tableEnvironment.registerCatalog("cat", new CustomCatalog("cat"));
Review Comment:
That's a good question
So far I only aware of FLINK-36482 however there is not so much done (linked
PR doesn't contained relevant info (yet)).
> I think createCatalog is not and should not be a directed replacement for
registerCatalog.
the reason I suggested it is the actual javadoc telling about this (should
the javadoc be changed?)
https://github.com/apache/flink/blob/8ada0ba123e99a408e7bafc8bcf90057d38d20b7/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java#L392-L397
However I agree that it is not very straightforward and I failed to find any
existing usage of that...
I'm also ok with current approach as there is a dedicated jira issue
let's hope this question will be clarified while the work within FLINK-36482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
