twalthr commented on code in PR #25952:
URL: https://github.com/apache/flink/pull/25952#discussion_r1917004026
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/NonDeterministicDagTest.xml:
##########
@@ -2462,28 +2462,23 @@
LogicalSink(table=[default_catalog.default_database.sink2], fields=[a, day, b, c
</Resource>
<Resource name="optimized exec plan">
<![CDATA[
-Exchange(distribution=[hash[a]])(reuse_id=[1])
-+- Calc(select=[a, DATE_FORMAT(CURRENT_TIMESTAMP(), 'yyMMdd') AS day])
- +- TableSourceScan(table=[[default_catalog, default_database, src1,
project=[a], metadata=[]]], fields=[a])
-
-TableSourceScan(table=[[default_catalog, default_database, src2, project=[b,
c, d], metadata=[]]], fields=[b, c, d])(reuse_id=[2])
+Join(joinType=[InnerJoin], where=[(a = d)], select=[a, b, day, b0, day0, c,
d], leftInputSpec=[NoUniqueKey], rightInputSpec=[NoUniqueKey])(reuse_id=[1])
Review Comment:
that's great!
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ResolvedCatalogView.java:
##########
@@ -37,10 +40,18 @@ public final class ResolvedCatalogView
private final ResolvedSchema resolvedSchema;
+ private final @Nullable CatalogView resolvedView;
+
public ResolvedCatalogView(CatalogView origin, ResolvedSchema
resolvedSchema) {
+ this(origin, resolvedSchema, null);
+ }
+
+ public ResolvedCatalogView(
+ CatalogView origin, ResolvedSchema resolvedSchema, CatalogView
resolvedView) {
Review Comment:
Can we avoid these changes? We don't necessarily need to keep the origin.
For CatalogTable it is more important than for views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
