dawidwys commented on code in PR #25952:
URL: https://github.com/apache/flink/pull/25952#discussion_r1916179773
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java:
##########
@@ -177,6 +177,31 @@ void testTimeAttributeOfView() {
+ "GROUP BY window_start, window_end");
}
+ @TestTemplate
+ void testTimeAttributeOfViewSelect() {
+ if (!streamingMode) {
+ // time attributes not supported in batch
+ return;
+ }
+ TableTestUtil testUtil = getTestUtil();
+ TableEnvironment tableEnvironment = testUtil.getTableEnv();
+ tableEnvironment.registerCatalog("cat", new CustomCatalog("cat"));
Review Comment:
> the reason I suggested it is the actual javadoc telling about this (should
the javadoc be changed?)
It was a valid question, I agree. I was not part of the discussion on
deprecating `registerCatalog`, not sure if this was discussed. I'll post my
comment on the issue you linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
