dawidwys commented on code in PR #25952:
URL: https://github.com/apache/flink/pull/25952#discussion_r1913082231


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java:
##########
@@ -177,6 +177,31 @@ void testTimeAttributeOfView() {
                         + "GROUP BY window_start, window_end");
     }
 
+    @TestTemplate
+    void testTimeAttributeOfViewSelect() {
+        if (!streamingMode) {
+            // time attributes not supported in batch
+            return;
+        }
+        TableTestUtil testUtil = getTestUtil();
+        TableEnvironment tableEnvironment = testUtil.getTableEnv();

Review Comment:
   Please ask them to verify again, cause it does not pass without the changes 
here, if you have https://issues.apache.org/jira/browse/FLINK-36883 applied.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to