snuyanzin commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3312763182
##########
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserRexNodeConverter.java:
##########
@@ -926,4 +925,16 @@ private InputCtx(
this.offsetInCalciteSchema = offsetInCalciteSchema;
}
}
+
+ /**
+ * Check via class name since GenericUDFCase was removed in Hive 4.1+.
+ *
+ * <p>TODO: Consider moving this check to HiveShim for consistency with
other version-dependent
+ * class checks.
+ */
+ private static boolean isGenericUDFCase(Object udf) {
+ return udf.getClass()
+ .getName()
+
.equals("org.apache.hadoop.hive.ql.udf.generic.GenericUDFCase");
Review Comment:
I didn't get this: initially there was a check for `instanceof` why are we
checking for class name equals now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
