jlalwani-amazon commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3312916179
##########
flink-connector-hive/pom.xml:
##########
@@ -1425,5 +1427,78 @@ under the License.
<jdk>[11,)</jdk>
</activation>
</profile>
+ <profile>
+ <id>hive4</id>
+ <properties>
+ <hive.version>4.0.0</hive.version>
+ <hive.hadoop.version>3.3.6</hive.hadoop.version>
+
<hive4.datanucleus-api-jdo.version>5.2.8</hive4.datanucleus-api-jdo.version>
+
<hive4.datanucleus-rdbms.version>5.2.10</hive4.datanucleus-rdbms.version>
+ </properties>
+ <dependencies>
+ <!--
+ hive-exec 4.x bundles protobuf 3.x
(unshaded). Override the transitive
+ protobuf 2.5.0 from Hadoop so the
bundled ORC/protobuf code works on
+ the flat test classpath. The production
fat jar handles this via shading.
+ -->
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.3.0</version>
+ <scope>test</scope>
Review Comment:
flink-connector-hive-e2e-tests tests with shaded jars. I'll double check if
we are testing with Hive 4 shaded jars and add tests if neccesary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
