jlalwani-amazon commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3312855444
##########
flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java:
##########
@@ -575,4 +584,57 @@ void ensureSupportedFlinkDate(Object flinkDate) {
LocalDate.class.getName(),
flinkDate.getClass().getName());
}
+
+ @Override
+ public List<String> getStructFieldNames(StructTypeInfo structTypeInfo) {
+ return new ArrayList<>(structTypeInfo.getAllStructFieldNames());
+ }
+
+ @Override
+ public List<TypeInfo> getStructFieldTypeInfos(StructTypeInfo
structTypeInfo) {
+ return new ArrayList<>(structTypeInfo.getAllStructFieldTypeInfos());
+ }
+
+ @Override
+ public void initializeSerDe(
+ Deserializer deserializer,
+ Configuration conf,
+ Properties tableProperties,
+ Properties partitionProperties)
+ throws SerDeException {
+ SerDeUtils.initializeSerDe(deserializer, conf, tableProperties,
partitionProperties);
+ }
+
+ @Override
+ public Object createPrincipalDesc(String principalName, PrincipalType
principalType) {
+ return new org.apache.hadoop.hive.ql.plan.PrincipalDesc(principalName,
principalType);
Review Comment:
Hive 3 and Hive 2 had `PrincipalDesc` in
`org.apache.hadoop.hive.ql.plan`.Hive 4 moved it to
`org.apache.hadoop.hive.ql.ddl.privilege` . I put the FQN here to make it clear
that this is returning the Hive 2/3 class not the Hive 4 class. I can change it
to import at the top. I thought this would make then code more clear.
Also, I realized that I'm not doing the same thing in Hive4 shim. It is
inconsistent. I'll move the class to import in all shims
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
