jlalwani-amazon commented on code in PR #37: URL: https://github.com/apache/flink-connector-hive/pull/37#discussion_r3313103371
########## flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserQBSubQuery.java: ########## @@ -25,7 +25,7 @@ import org.apache.calcite.plan.RelOptCluster; import org.apache.calcite.tools.FrameworkConfig; -import org.apache.hadoop.hive.common.ObjectPair; +import org.apache.commons.lang3.tuple.MutablePair; Review Comment: ObjectPair is mutable. MutablePair is the closest match. We can use ImmutablePair. It would require larger change. All instances of MutablePair are local. There shouldn't be any concurrency concerns with use of MutablePair -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
