[ 
https://issues.apache.org/jira/browse/HAWQ-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113367#comment-15113367
 ] 

ASF GitHub Bot commented on HAWQ-340:
-------------------------------------

GitHub user sansanichfb opened a pull request:

    https://github.com/apache/incubator-hawq/pull/290

    HAWQ-340. Make getVersion API return JSON format.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-hawq HAWQ-340

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
    
----
commit cf03aa9309b93a05fe36949e10cdd6d695440e61
Author: Oleksandr Diachenko <[email protected]>
Date:   2016-01-22T23:58:06Z

    HAWQ-340. Make getVersion API return JSON format.

----


> Make getVersion API return JSON format
> --------------------------------------
>
>                 Key: HAWQ-340
>                 URL: https://issues.apache.org/jira/browse/HAWQ-340
>             Project: Apache HAWQ
>          Issue Type: Sub-task
>          Components: PXF
>            Reporter: Goden Yao
>            Assignee: Goden Yao
>             Fix For: 2.0.0
>
>
> It's best practice to return in JSON format.
> current return string looks like this: 
> {code}
>  b.entity("PXF protocol version " + Version.PXF_PROTOCOL_VERSION);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to