[jira] [Commented] (HAWQ-340) Make getVersion API return JSON format

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HAWQ-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116143#comment-15116143
 ] 

ASF GitHub Bot commented on HAWQ-340:
-------------------------------------

Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/290#discussion_r50761090
  
    --- Diff: pxf/build.gradle ---
    @@ -122,6 +124,42 @@ subprojects { subProject ->
     }
     
     project('pxf-service') {
    +
    +
    +    task generateSources {
    --- End diff --
    
    Sure, let me add comments.


> Make getVersion API return JSON format
> --------------------------------------
>
>                 Key: HAWQ-340
>                 URL: https://issues.apache.org/jira/browse/HAWQ-340
>             Project: Apache HAWQ
>          Issue Type: Sub-task
>          Components: PXF
>            Reporter: Goden Yao
>            Assignee: Goden Yao
>             Fix For: 2.0.0
>
>
> It's best practice to return in JSON format.
> current return string looks like this: 
> {code}
>  b.entity("PXF protocol version " + Version.PXF_PROTOCOL_VERSION);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)