[
https://issues.apache.org/jira/browse/HAWQ-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116093#comment-15116093
]
ASF GitHub Bot commented on HAWQ-340:
-------------------------------------
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/290#discussion_r50758859
--- Diff: pxf/build.gradle ---
@@ -122,6 +124,42 @@ subprojects { subProject ->
}
project('pxf-service') {
+
+
+ task generateSources {
--- End diff --
can you please add a comment in the code explaining the basic idea here? If
I understand correctly, we replace any mention of @pxfProtocolVersion@ with the
value from gradle.properties?
> Make getVersion API return JSON format
> --------------------------------------
>
> Key: HAWQ-340
> URL: https://issues.apache.org/jira/browse/HAWQ-340
> Project: Apache HAWQ
> Issue Type: Sub-task
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Fix For: 2.0.0
>
>
> It's best practice to return in JSON format.
> current return string looks like this:
> {code}
> b.entity("PXF protocol version " + Version.PXF_PROTOCOL_VERSION);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
