[
https://issues.apache.org/jira/browse/HAWQ-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116145#comment-15116145
]
ASF GitHub Bot commented on HAWQ-340:
-------------------------------------
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/290#discussion_r50761112
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/VersionResource.java
---
@@ -33,7 +34,7 @@
* version e.g. {@code ...pxf/v14/Bridge}
*/
class Version {
- final static String PXF_PROTOCOL_VERSION = "v14";
+ final static String PXF_PROTOCOL_VERSION = "@pxfProtocolVersion@";
--- End diff --
Will add explanation.
> Make getVersion API return JSON format
> --------------------------------------
>
> Key: HAWQ-340
> URL: https://issues.apache.org/jira/browse/HAWQ-340
> Project: Apache HAWQ
> Issue Type: Sub-task
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Fix For: 2.0.0
>
>
> It's best practice to return in JSON format.
> current return string looks like this:
> {code}
> b.entity("PXF protocol version " + Version.PXF_PROTOCOL_VERSION);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
