[
https://issues.apache.org/jira/browse/HAWQ-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116185#comment-15116185
]
ASF GitHub Bot commented on HAWQ-340:
-------------------------------------
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/290#discussion_r50765934
--- Diff:
pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/rest/VersionResourceTest.java
---
@@ -36,7 +36,7 @@ public void getProtocolVersion() throws Exception {
assertEquals(Response.Status.OK,
Response.Status.fromStatusCode(result.getStatus()));
- assertEquals("PXF protocol version " +
Version.PXF_PROTOCOL_VERSION,
+ assertEquals("{ \"version\": \"" + Version.PXF_PROTOCOL_VERSION +
"\"}",
--- End diff --
Sure, good catch.
> Make getVersion API return JSON format
> --------------------------------------
>
> Key: HAWQ-340
> URL: https://issues.apache.org/jira/browse/HAWQ-340
> Project: Apache HAWQ
> Issue Type: Sub-task
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Fix For: 2.0.0
>
>
> It's best practice to return in JSON format.
> current return string looks like this:
> {code}
> b.entity("PXF protocol version " + Version.PXF_PROTOCOL_VERSION);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
