[
https://issues.apache.org/jira/browse/HAWQ-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116513#comment-15116513
]
ASF GitHub Bot commented on HAWQ-340:
-------------------------------------
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/290#discussion_r50788596
--- Diff:
pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/rest/VersionResourceTest.java
---
@@ -22,21 +22,26 @@
import static org.junit.Assert.assertEquals;
+import javax.ws.rs.core.HttpHeaders;
+import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
import org.junit.Test;
public class VersionResourceTest {
- @Test
- public void getProtocolVersion() throws Exception {
+ @Test
+ public void getProtocolVersion() throws Exception {
- VersionResource resource = new VersionResource();
- Response result = resource.getProtocolVersion();
+ VersionResource resource = new VersionResource();
--- End diff --
@shivzone thanks, fixed.
> Make getVersion API return JSON format
> --------------------------------------
>
> Key: HAWQ-340
> URL: https://issues.apache.org/jira/browse/HAWQ-340
> Project: Apache HAWQ
> Issue Type: Sub-task
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Fix For: 2.0.0
>
>
> It's best practice to return in JSON format.
> current return string looks like this:
> {code}
> b.entity("PXF protocol version " + Version.PXF_PROTOCOL_VERSION);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
