[
https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876007#action_12876007
]
HBase Review Board commented on HBASE-2618:
-------------------------------------------
Message from: "Benoit Sigoure" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/#review134
-----------------------------------------------------------
Actually, I'm thinking that now we can turn HConstants in a `public final
class' instead of an `interface'. This would prevent further uses of the
Constant Interface Antipattern
(http://java.sun.com/j2se/1.5.0/docs/guide/language/static-import.html).
Anyone opposed to me doing this as part of this patch?
- Benoit
> Don't inherit from HConstants
> -----------------------------
>
> Key: HBASE-2618
> URL: https://issues.apache.org/jira/browse/HBASE-2618
> Project: HBase
> Issue Type: Wish
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants? This is a known bad
> pattern and is recommended against in many places including Effective Java
> (item 17).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
