[
https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876051#action_12876051
]
HBase Review Board commented on HBASE-2618:
-------------------------------------------
Message from: "Jonathan Gray" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/#review135
-----------------------------------------------------------
This patch changes a bunch of tabbing patterns to be different from what is
currently done in the codebase. Primarily the full indenting of arguments to
align with each other.
As far as I know, this format is not used anywhere else in HBase. I don't
think patches to clean up HConstants inheriting should do a partial change to a
different style for something unrelated?
- Jonathan
> Don't inherit from HConstants
> -----------------------------
>
> Key: HBASE-2618
> URL: https://issues.apache.org/jira/browse/HBASE-2618
> Project: HBase
> Issue Type: Wish
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants? This is a known bad
> pattern and is recommended against in many places including Effective Java
> (item 17).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
