[
https://issues.apache.org/jira/browse/HBASE-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895143#action_12895143
]
HBase Review Board commented on HBASE-2697:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/484/#review658
-----------------------------------------------------------
Here's a bit more on the TODO and the comments on patch.
branches/0.90_master_rewrite/BRANCH_TODO.txt
<http://review.cloudera.org/r/484/#comment2443>
First some comments on your summary:
"I completely ripped out BaseScanner/MetaScanner as well as the
RegionServerOperationQueue stuff. I'm sold on the former ... The BaseScanner
is no longer necessary because we are not utilizing META to determine when
things are unassigned.
"
How are splits to work then? The RS does insert into META? But if it
doesn't do all inserts -- fails between offlining of parent and addition of
daughters to meta -- we'll need the fixup for when a split is not fully
reported. This used to be done in basescanner.
"might need a new CREATED unassigned now, or new rpc, but get rid of
sending split notification on heartbeat?"
Who'd make the above CREATED?
"figure what to do with client table admin ops (flush, split, compact)"
The operations are in place, you are just asking about how to send the
messages?
branches/0.90_master_rewrite/BRANCH_TODO.txt
<http://review.cloudera.org/r/484/#comment2444>
Why would they be updating the same row?
branches/0.90_master_rewrite/BRANCH_TODO.txt
<http://review.cloudera.org/r/484/#comment2446>
You renamed these classes or the ZK changes are done?
branches/0.90_master_rewrite/BRANCH_TODO.txt
<http://review.cloudera.org/r/484/#comment2447>
I like just reusing is meta idea for now
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
<http://review.cloudera.org/r/484/#comment2448>
No benefit to be got making this a NavigableMap/SortedMap?
- stack
> Implement new open/close logic in handlers and stop using heartbeats for
> open/close messages
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-2697
> URL: https://issues.apache.org/jira/browse/HBASE-2697
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, regionserver
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> This issue is doing the meat of what HBASE-2485 is about and continues what
> was started in HBASE-2694 after some code cleanup to make life easier.
> This deals with no longer piggybacking messages from Master to RegionServers
> on heartbeat responses and instead sending direct unsolicited messages. This
> also deals with moving the open/close logic fully into handlers and removing
> the existing open/close code on both the RS and M sides. There may also be
> some changes to the master in-memory state of regions in transition. The new
> load balancer will probably be introduced with this issue but not fully
> integrated yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
