[ 
https://issues.apache.org/jira/browse/HBASE-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984539#comment-13984539
 ] 

stack commented on HBASE-11093:
-------------------------------

bq. Do you think removal of hasFilterRow is something that should be pursued 
for 1.0 release ?

When asked about hasFilterRow by Anoop, you say it an issue of obtaining 
consensus (I respond to this remark of yours). Now it is an issue of 
compatibility. Regardless you don't answer my question (is it a better path to 
remove hasFilterRow?).  It is hard to follow what you are at [~ted_yu] and your 
motivations.  It makes it hard contributing helpful review.

> FilterList#filterRow() iterates through its filters even though 
> FilterList#hasFilterRow() returns false
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11093
>                 URL: https://issues.apache.org/jira/browse/HBASE-11093
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 11093-v1.txt, 11093-v2.txt, 11093-v3.txt
>
>
> FilterList#hasFilterRow() returns false when hasFilterRow() of all of 
> constituent filters return false.
> However, FilterList#filterRow() still iterates through its filters in this 
> scenario.
> The iteration should be skipped when FilterList#hasFilterRow() returns false.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to