[ 
https://issues.apache.org/jira/browse/HBASE-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985145#comment-13985145
 ] 

Ted Yu commented on HBASE-11093:
--------------------------------

User filter should follow Filter javadoc, which is clear since 0.96+, and 
implement hasFilterRow() accordingly.
The snippet cited above makes filtering inefficient and somewhat hard to 
predict.

We should make a decision as to which release drops this snippet.

> FilterList#filterRow() iterates through its filters even though 
> FilterList#hasFilterRow() returns false
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11093
>                 URL: https://issues.apache.org/jira/browse/HBASE-11093
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 11093-v1.txt, 11093-v2.txt, 11093-v3.txt
>
>
> FilterList#hasFilterRow() returns false when hasFilterRow() of all of 
> constituent filters return false.
> However, FilterList#filterRow() still iterates through its filters in this 
> scenario.
> The iteration should be skipped when FilterList#hasFilterRow() returns false.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to