[ 
https://issues.apache.org/jira/browse/HBASE-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985134#comment-13985134
 ] 

Anoop Sam John commented on HBASE-11093:
----------------------------------------

In HRegion#RegionScannerImpl
Wherever we call filterRowCells() or filterRow() we have hasFilterRow() checks 
prior to those.. 
{code}
private boolean filterRow() throws IOException {
  // when hasFilterRow returns true, filter.filterRow() will be called 
automatically inside
  // filterRowCells(List<Cell> kvs) so we skip that scenario here.
  return filter != null && (!filter.hasFilterRow())
          && filter.filterRow();
}
{code}
For BC we make above code. Here even if hasFilterRow is false we have to call 
filterRow().  With this patch, we will fail to call filterRow() right?

> FilterList#filterRow() iterates through its filters even though 
> FilterList#hasFilterRow() returns false
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11093
>                 URL: https://issues.apache.org/jira/browse/HBASE-11093
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 11093-v1.txt, 11093-v2.txt, 11093-v3.txt
>
>
> FilterList#hasFilterRow() returns false when hasFilterRow() of all of 
> constituent filters return false.
> However, FilterList#filterRow() still iterates through its filters in this 
> scenario.
> The iteration should be skipped when FilterList#hasFilterRow() returns false.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to