[ 
https://issues.apache.org/jira/browse/HBASE-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143904#comment-14143904
 ] 

stack commented on HBASE-12041:
-------------------------------

In 0.98, we did thisin the HFPE write:

append(final byte[] key, final byte[] value)
called straight through to
protected void append(final long memstoreTS, final byte[] key, final int 
koffset,
 final int klength, final byte[] value, final int voffset, final int vlength)
.... with follows: append(0, key, 0, key.length, value, 0, value.length);

Now we have 'interpretation' of the arrays passed going on.  The presumption is 
that the passed bytes are serialized using old-school KeyValue:

append(final byte[] key, final byte[] value)... ends up creating a KeyValue on 
the end out of the 'key' and the 'value' only it will trips when it goes to 
parse the content.

We need to look at the Writer API [~anoop.hbase] and 
[[email protected]]  You fellas probably already have ideas here 
(Odd that HFile#Writer takes a Cell when it is going to write a key and a 
value... should we be passing in a serializer/deserialzier too? ... or HFile 
should not know anything about Cell or KeyValue.  There is the Comparator... 
which does bytes only which should be fine...).

Since this is a HFilePE test and not a Cell or KV test, I think I should 
expose....

protected void append(final long memstoreTS, final byte[] key, final int 
koffset,
 final int klength, final byte[] value, final int voffset, final int vlength)

... for 'testing'.



> AssertionError in HFilePerformanceEvaluation.UniformRandomReadBenchmark
> -----------------------------------------------------------------------
>
>                 Key: HBASE-12041
>                 URL: https://issues.apache.org/jira/browse/HBASE-12041
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.1
>            Reporter: Jean-Marc Spaggiari
>            Assignee: stack
>
> {code}
> 2014-09-19 05:18:54,719 INFO  [0] hbase.HFilePerformanceEvaluation: Running 
> UniformRandomReadBenchmark for 1000000 rows.
> 2014-09-19 05:18:54,719 INFO  [0] hfile.CacheConfig: CacheConfig:disabled
> Exception in thread "0" java.lang.AssertionError: Expected 0000472128 but got 
> 0000472127
>         at 
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:50)
>         at 
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:45)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$UniformRandomReadBenchmark.doRow(HFilePerformanceEvaluation.java:295)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$RowOrientedBenchmark.run(HFilePerformanceEvaluation.java:169)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation.runBenchmark(HFilePerformanceEvaluation.java:121)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$2.run(HFilePerformanceEvaluation.java:87)
>         at java.lang.Thread.run(Thread.java:744)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to