[
https://issues.apache.org/jira/browse/HBASE-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144342#comment-14144342
]
stack commented on HBASE-12041:
-------------------------------
[~jmspaggi]
bq. seems that anyway there will be already many updates required compared to
0.98 and test will not really be identical.
Yeah, I think this the case boss.
bq. IMO the tests also should pass Cells.(KeyValue objects)
... and we should deprecate those appends that take key, value, and tag byte
arrays? (I started to do it but its a little bit of a rad change).
[~anoop.hbase] Was thinking on this more. You can't pass a Cell to a Writer
w/o also passing how to serialize and deserialize? Right? So we need to pass
comparator, serializer, and Cells themselves? In Writer, it needs to be able
to figure key to add to the hfile index at least. It wants the comparator to
ensure all is in order. We then pass the Cell through to DBE. That does the
actual serializing. It needs serializer too? Or, rather, it is THE Serializer
We should ask DBE to serialize the key to add to the index? We should make
the NONE DBE do the KV serialization rather than do it in upper levels?
> AssertionError in HFilePerformanceEvaluation.UniformRandomReadBenchmark
> -----------------------------------------------------------------------
>
> Key: HBASE-12041
> URL: https://issues.apache.org/jira/browse/HBASE-12041
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.1
> Reporter: Jean-Marc Spaggiari
> Assignee: stack
>
> {code}
> 2014-09-19 05:18:54,719 INFO [0] hbase.HFilePerformanceEvaluation: Running
> UniformRandomReadBenchmark for 1000000 rows.
> 2014-09-19 05:18:54,719 INFO [0] hfile.CacheConfig: CacheConfig:disabled
> Exception in thread "0" java.lang.AssertionError: Expected 0000472128 but got
> 0000472127
> at
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:50)
> at
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:45)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$UniformRandomReadBenchmark.doRow(HFilePerformanceEvaluation.java:295)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$RowOrientedBenchmark.run(HFilePerformanceEvaluation.java:169)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation.runBenchmark(HFilePerformanceEvaluation.java:121)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$2.run(HFilePerformanceEvaluation.java:87)
> at java.lang.Thread.run(Thread.java:744)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
