[
https://issues.apache.org/jira/browse/HBASE-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144206#comment-14144206
]
Anoop Sam John commented on HBASE-12041:
----------------------------------------
I see. The change we done in HBASE-11874.
>From code we always pass Cell to the Writer. We read the row/family lengths
>etc and serialize those compartments (as how we do in a KV). In the past we
>used to pass KV and we relied on the fact that all items are backed by single
>byte array and just copied the single array as is. So at that time passing key
>and value bytes for test made more sense. Now as the core code flow is
>changed, IMO the tests also should pass Cells.(KeyValue objects)
bq.HFile should not know anything about Cell or KeyValue.
Yes. the V2/V3 version writer writes the Cell compartments as contiguous bytes
(This end up in KV serialization way as we used to do this way) and
corresponding reader version knows how to interpret these bytes back to Cells.
That sounds good to me.
{quote}
Since this is a HFilePE test and not a Cell or KV test, I think I should
expose....
protected void append(final long memstoreTS, final byte[] key, final int
koffset,
final int klength, final byte[] value, final int voffset, final int vlength)
{quote}
I think append(Cell) itself can be used from this tool. Some of the tests were
using this API and I changed those along with HBASE-11874 but missed tool.
> AssertionError in HFilePerformanceEvaluation.UniformRandomReadBenchmark
> -----------------------------------------------------------------------
>
> Key: HBASE-12041
> URL: https://issues.apache.org/jira/browse/HBASE-12041
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.1
> Reporter: Jean-Marc Spaggiari
> Assignee: stack
>
> {code}
> 2014-09-19 05:18:54,719 INFO [0] hbase.HFilePerformanceEvaluation: Running
> UniformRandomReadBenchmark for 1000000 rows.
> 2014-09-19 05:18:54,719 INFO [0] hfile.CacheConfig: CacheConfig:disabled
> Exception in thread "0" java.lang.AssertionError: Expected 0000472128 but got
> 0000472127
> at
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:50)
> at
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:45)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$UniformRandomReadBenchmark.doRow(HFilePerformanceEvaluation.java:295)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$RowOrientedBenchmark.run(HFilePerformanceEvaluation.java:169)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation.runBenchmark(HFilePerformanceEvaluation.java:121)
> at
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$2.run(HFilePerformanceEvaluation.java:87)
> at java.lang.Thread.run(Thread.java:744)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
