[ 
https://issues.apache.org/jira/browse/HBASE-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144383#comment-14144383
 ] 

stack commented on HBASE-12041:
-------------------------------

bq. It is THE serializer IMO.

Ok. Lets go w/ this.

bq. Atleast to the index we write the key as it would look like in KV. So I am 
not sure whether it will be correct to ask the DBE to create a key to be added 
to index .

OK.  We need to do better than this though:

      firstKeyInBlock = new byte[klength];
      KeyValueUtil.appendKeyTo(cell, firstKeyInBlock, 0);

That is what we currently have.  Could have an Index Serializer interface. For 
now could do the basic implementation?  Needs to retain sort.

bq. That is the writer decides the way.

We pass in the KVComparator.  We should clean this up too?  Not pass in a 
comparator from KV?

You down with deprecating the Writer.appends that take byte arrays that are 
supposed to be in KeyValue Key and Value formats?



> AssertionError in HFilePerformanceEvaluation.UniformRandomReadBenchmark
> -----------------------------------------------------------------------
>
>                 Key: HBASE-12041
>                 URL: https://issues.apache.org/jira/browse/HBASE-12041
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.1
>            Reporter: Jean-Marc Spaggiari
>            Assignee: stack
>
> {code}
> 2014-09-19 05:18:54,719 INFO  [0] hbase.HFilePerformanceEvaluation: Running 
> UniformRandomReadBenchmark for 1000000 rows.
> 2014-09-19 05:18:54,719 INFO  [0] hfile.CacheConfig: CacheConfig:disabled
> Exception in thread "0" java.lang.AssertionError: Expected 0000472128 but got 
> 0000472127
>         at 
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:50)
>         at 
> org.apache.hadoop.hbase.PerformanceEvaluationCommons.assertKey(PerformanceEvaluationCommons.java:45)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$UniformRandomReadBenchmark.doRow(HFilePerformanceEvaluation.java:295)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$RowOrientedBenchmark.run(HFilePerformanceEvaluation.java:169)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation.runBenchmark(HFilePerformanceEvaluation.java:121)
>         at 
> org.apache.hadoop.hbase.HFilePerformanceEvaluation$2.run(HFilePerformanceEvaluation.java:87)
>         at java.lang.Thread.run(Thread.java:744)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to