[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294568#comment-14294568
]
Hadoop QA commented on HBASE-12859:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12694718/12859-v5.txt
against master branch at commit 0f6faaf5fc60b7fb3ffe1a77cdd21430efddcc11.
ATTACHMENT ID: 12694718
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1943 checkstyle errors (more than the master's current 1936 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
.setRegion(RequestConverter.buildRegionSpecifier(RegionSpecifierType.REGION_NAME,
regionName)).build();
+ new java.lang.String[] { "RegionSpecifier", "Stores",
"Storefiles", "StoreUncompressedSizeMB", "StorefileSizeMB", "MemstoreSizeMB",
"StorefileIndexSizeMB", "ReadRequestsCount", "WriteRequestsCount",
"TotalCompactingKVs", "CurrentCompactedKVs", "RootIndexSizeKB",
"TotalStaticIndexSizeKB", "TotalStaticBloomSizeKB", "CompleteSequenceId",
"DataLocality", "LastMajorCompactionTs", });
+ * <code>rpc
getLastMajorCompactionTimestamp(.MajorCompactionTimestampRequest) returns
(.MajorCompactionTimestampResponse);</code>
+ * <code>rpc
getLastMajorCompactionTimestampForRegion(.MajorCompactionTimestampForRegionRequest)
returns (.MajorCompactionTimestampResponse);</code>
+ * <code>rpc
getLastMajorCompactionTimestamp(.MajorCompactionTimestampRequest) returns
(.MajorCompactionTimestampResponse);</code>
+ * <code>rpc
getLastMajorCompactionTimestampForRegion(.MajorCompactionTimestampForRegionRequest)
returns (.MajorCompactionTimestampResponse);</code>
+ rpc getLastMajorCompactionTimestamp(MajorCompactionTimestampRequest)
returns(MajorCompactionTimestampResponse);
+ rpc
getLastMajorCompactionTimestampForRegion(MajorCompactionTimestampForRegionRequest)
returns(MajorCompactionTimestampResponse);
+ fileInfo.append(FileInfo.CREATE_TIME_TS,
Bytes.toBytes(hFileContext.getFileCreateTime()), false);
+ MajorCompactionTimestampResponse.Builder response =
MajorCompactionTimestampResponse.newBuilder();
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12610//console
This message is automatically generated.
> Major compaction completion tracker
> -----------------------------------
>
> Key: HBASE-12859
> URL: https://issues.apache.org/jira/browse/HBASE-12859
> Project: HBase
> Issue Type: Brainstorming
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 2.0.0, 0.98.10, 1.0.1
>
> Attachments: 12859-v1.txt, 12859-v2.txt, 12859-v3.txt, 12859-v4.txt,
> 12859-v5.txt, 12859-wip-UNFINISHED.txt
>
>
> In various scenarios it is helpful to know a guaranteed timestamp up to which
> all data in a table was major compacted.
> We can do that keeping a major compaction timestamp in META.
> A client then can iterate all region of a table and find a definite
> timestamp, which is the oldest compaction timestamp of any of the regions.
> [~apurtell], [~ghelmling], [~giacomotaylor].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
