[
https://issues.apache.org/jira/browse/HBASE-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294802#comment-14294802
]
stack commented on HBASE-12859:
-------------------------------
nit: getLastMajorCompactionTsForTable should have a comment explaining it can
return zero and what that means.
I don't get this bit (or in other words, please explain it to me):
+ * Get the timestamp of the last major compaction for the passed table
+ * (the timestamp of the oldest HFile of that table)
How is ts of oldest HFile the last major compaction time?
This attribute of crate time will only be available in certain hfile versions?
I'd think the fileinfo already loaded so this is a noop?
+ byte[] val =
reader.loadFileInfo().get(StoreFile.MAJOR_COMPACTION_KEY);
Patch is great. Nice.
> Major compaction completion tracker
> -----------------------------------
>
> Key: HBASE-12859
> URL: https://issues.apache.org/jira/browse/HBASE-12859
> Project: HBase
> Issue Type: Brainstorming
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 2.0.0, 0.98.10, 1.1.0
>
> Attachments: 12859-v1.txt, 12859-v2.txt, 12859-v3.txt, 12859-v4.txt,
> 12859-v5.txt, 12859-v6.txt, 12859-wip-UNFINISHED.txt
>
>
> In various scenarios it is helpful to know a guaranteed timestamp up to which
> all data in a table was major compacted.
> We can do that keeping a major compaction timestamp in META.
> A client then can iterate all region of a table and find a definite
> timestamp, which is the oldest compaction timestamp of any of the regions.
> [~apurtell], [~ghelmling], [~giacomotaylor].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
