[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406910#comment-15406910
]
Enis Soztutar commented on HBASE-15893:
---------------------------------------
Thanks [~sudeeps] for the new patch.
- Why is this part of the API? It is an internal function:
{code}
+ static ReturnCode CheckRow(const std::string &row);
{code}
do we need ReturnCode at all?
- Should be named {{Consistency}}:
{code}
+enum CONSISTENCY {
{code}
- Multiple methods in get are declared with arguments passed as references,
even though they are primitive types. Is this standard in C++ land? Shouldn't
we do pass-by-value if primitive, and pass-by-reference otherwise? Sorry I am
not up-to-date on C++ best practices. Same thing for returned results.
{code}
+ Get& SetMaxVersions(const int&);
+ Get& SetCacheBlocks(const bool&);
...
{code}
- Why NumFamilies() instead of getFamilyMap()?
+const int Get::NumFamilies() const {
- We don't need this (it was removed some time ago, but we forgot to deprecate
the PB field):
{code}
+ bool closest_row_before_;
{code}
- Should be {{IsAllTime()}} ?
{code}
+ bool GetAllTime() const;
{code}
- Remove these?
{code}
+ /*std::string error_str(
{code}
> Get object
> ----------
>
> Key: HBASE-15893
> URL: https://issues.apache.org/jira/browse/HBASE-15893
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Assignee: Sudeep Sunthankar
> Attachments: HBASE-15893.HBASE-14850.v1.patch,
> HBASE-15893.HBASE-14850.v2.patch
>
>
> Patch for creating Get objects. Get objects can be passed to the Table
> implementation to fetch results for a given row.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
