[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409785#comment-15409785
]
Elliott Clark commented on HBASE-15893:
---------------------------------------
* None of this is hooked up to the client.
* No Get before getters. Eg GetMaxVersions becomes MaxVersions
* No comments on most of the classes or methods.
* Don't make Get's destructor virtual until we need to. We shouldn't be
planning to have Get be extendable until we need it.
* GET_FAMILY_MAP is pretty badly named.
* Should we be using shared pointers for ownership of strings in get?
* hbase-native-client/core/get-test.cc no need to include glog. You're not
using it.
* prefer constexpr over const static in a class. Better yet just don't expose
that constant at all.
* Don't use unique pointer in time range tests. Tests should be examples of how
we expect people to create objects and nothing uses unique pointers.
* Max versions should be a uint32_t
* default for SetMaxVersions should be in line with the type and should be the
same default as our other clients. ( 1 )
* We already have a Consistency enum don't duplicate that.
* Please please don't copy paste.
{code} @throws IllegalArgumentException{code}
> Get object
> ----------
>
> Key: HBASE-15893
> URL: https://issues.apache.org/jira/browse/HBASE-15893
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Assignee: Sudeep Sunthankar
> Attachments: HBASE-15893.HBASE-14850.v1.patch,
> HBASE-15893.HBASE-14850.v2.patch, HBASE-15893.HBASE-14850.v3.patch
>
>
> Patch for creating Get objects. Get objects can be passed to the Table
> implementation to fetch results for a given row.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
