[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407895#comment-15407895
]
Sudeep Sunthankar commented on HBASE-15893:
-------------------------------------------
Thanks [~enis]
Please find my comments below
{panel}+static ReturnCode CheckRow(const std::string &row);{panel}
Instead of returning integer 0 for suceess and otherwise, have used an
enum which can be used for indicating error codes
{panel}+enum CONSISTENCY {
+bool closest_row_before_;
+bool GetAllTime() const;
+ /*std::string error_str({panel}
Will address in the subsequent patch
{panel}+NumFamilies() instead of getFamilyMap()?{panel}
We have an API GetFamily(); NumFamilies() was added as there is a
similar method in Java client
{panel}+Multiple methods in get are declared with arguments passed as
references, even though they are primitive types.{panel}
It is not required to pass primitive types as reference. Will address
the same in next patch
For returned results the reference is returned so that we can use
method chaining. (get.SetMaxVersions(4).SetCacheBlocks(false))
> Get object
> ----------
>
> Key: HBASE-15893
> URL: https://issues.apache.org/jira/browse/HBASE-15893
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Assignee: Sudeep Sunthankar
> Attachments: HBASE-15893.HBASE-14850.v1.patch,
> HBASE-15893.HBASE-14850.v2.patch
>
>
> Patch for creating Get objects. Get objects can be passed to the Table
> implementation to fetch results for a given row.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
