[ 
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411668#comment-15411668
 ] 

Sudeep Sunthankar commented on HBASE-15893:
-------------------------------------------

Thanks for the feedback [~eclark].

 We are working on your feedback. Could you please clarify some of my doubts
 
1) We already have a Consistency enum don't duplicate that
   -- Should we use the enum defined in if/Client.proto ? 
2) None of this is hooked up to the client. 
   -- Do you mean adding the tests to BUCK as is done in sub-task 51. 
3) Should we be using shared pointers for ownership of strings in get?
   -- Any specific reason for this 
   

> Get object
> ----------
>
>                 Key: HBASE-15893
>                 URL: https://issues.apache.org/jira/browse/HBASE-15893
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-15893.HBASE-14850.v1.patch, 
> HBASE-15893.HBASE-14850.v2.patch, HBASE-15893.HBASE-14850.v3.patch
>
>
> Patch for creating Get objects.  Get objects can be passed to the Table 
> implementation to fetch results for a given row. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to