[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276619#comment-16276619
]
Chia-Ping Tsai commented on HBASE-19112:
----------------------------------------
bq. Reading through your comments, I am not sure I get this fully. so when you
want to create a new cell with rewritten fields you will not use the Builder
(CellBuilder) where was you create a new Cell impl by passing the type byte (as
a byte) also to that new cell?
Yep.
bq. So can't we just use the CellBuilder way here too? And this is on the
client side I believe.
Using the CellBuilder to rewrite the code which aim at generating cell isn't a
problem. My concern is that we don't forbid user to have their Cell imp. If the
getTypeByte is removed from Cell, how can we get the type byte from cells
passed by user when converting the cells to proto? The cells in
Put/Append/Increment are always PUT, but the cells in Delete have different
Delete type..
bq. So if at all they need a cell to be prepared out of it they can use the
RawCellBuilder only (that does not allow setting of seqId)?
yep. We should have the RawCellBuilder for cp user as we allow cp user to have
their tag now.
> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Josh Elser
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
