[ 
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276638#comment-16276638
 ] 

ramkrishna.s.vasudevan commented on HBASE-19112:
------------------------------------------------

I think since we are now having CellBuilder.setType(DataType ) we need some way 
to get this DataType from the Cell.
I was thinking that getTypeByte() was already deprecated and we have some 
replacements for that but I can see that it just indicates if it is a Put or 
Delete. 
I think the  most simple way is to have a reverese of toKeyValueType() in 
ExtendedCellBuilderImpl and return the Datatype (that is already public) using 
a new CellUtil API. 
If user is actually creating Deletes and its variants using Delete.java then 
there is no issue. Only when he wants the Cell to be used directly in 
put.add(Cell) and Delete.add(Cell) he needs this type which can always be got 
from the new CellUtil API? What ever is the DataType available in CellBuilder 
let it continue. 

> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
>                 Key: HBASE-19112
>                 URL: https://issues.apache.org/jira/browse/HBASE-19112
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Josh Elser
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19112_branch-2.patch
>
>
> [~chia7712] suggested on the [mailing 
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
>  that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there 
> aren't others which are either implementation details or methods returning 
> now-private-marked classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to