[ 
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291948#comment-16291948
 ] 

ramkrishna.s.vasudevan commented on HBASE-19112:
------------------------------------------------

IMO I agree to it. I get your concern. So again the arg could if the custom 
cell is on the client side - then once the cell goes into server side then we 
are safe from that point onwards but the catch is that if on the client side we 
need to do CellComparator then we have an issue. 
So the @Public facing CellComparator internally should manage getType and 
getTypeByte as you said.

> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
>                 Key: HBASE-19112
>                 URL: https://issues.apache.org/jira/browse/HBASE-19112
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Josh Elser
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19112_branch-2.patch, 
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch, 
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch, 
> HBASE-19112_master_2.patch
>
>
> [~chia7712] suggested on the [mailing 
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
>  that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there 
> aren't others which are either implementation details or methods returning 
> now-private-marked classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to