[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291967#comment-16291967
]
Chia-Ping Tsai commented on HBASE-19112:
----------------------------------------
bq. This was on the client-side, right Chia? Not as a CP?
yep, my use case in on client-side.
bq. They dont have a contract for getTypeByte()
I think they must to have a contract for getTypeByte() if cp user try to add
the custom cell. We have different expectation of cell impl passed by
{{Put#add(Cell)}}. If cp users try to add custom cell to Put, they must to add
{{ExtendedCell}} since the RS need to update cell's timestamp and sequence id.
In contrast to cp user, adding the {{Cell}} to Put is ok on client side...
bq. CPs should be able to create Cells (with Tags) but custom Cells we should
disallow
Add the comment on Put#add(Cell) to say "DON'T add your custom cell impl on
server-side. Use CellBuilder instead"?
> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Josh Elser
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch,
> HBASE-19112_master_2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
