[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292075#comment-16292075
]
Chia-Ping Tsai commented on HBASE-19112:
----------------------------------------
bq. Ya setTs and seqId things must be there. Remembering now that
SettableTimeStamp and other interface were CP exposed for this reason.
Moving the setTs and seqId to RawCell mean that cp user can modify the
cells...I prefer to make {{Cell}} and {{RawCell}} be the read-only interface
since changing the ts and id in cp layer may cause a unknown result.
bq. I was not suggesting we should allow adding custom cells in CP.
Agreed. We can add comment on Put#add(Cell). Or pass a wrap put which do the
type check in add(Cell) to cp user?
{code:title=WrapPut.java}
@Override
public Put add(Cell kv) throws IOException {
if (kv instanceof ExtendedCell) {
super.add(kv);
}
throw new UnsupportedException("Only ExtendedCell can be added to Put in cp
layer")
}
{code}
> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Josh Elser
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch,
> HBASE-19112_master_2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
