[
https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384137#comment-16384137
]
stack commented on HBASE-20095:
-------------------------------
bq. Only one updates the static pool.
That makes sense [~reidchan].
nit... Does this method have to be public?
84 public static void initChorePool(Configuration conf) {
nit: static class members should be upper-case per usual java convention...
nit: could bundle the below up into a small inner class.... so only one
volatile, static reference.
73 private static volatile ForkJoinPool pool;
74 private static volatile int poolSize;
But +1 on patch. Get a review from [~mdrob] too. Thanks [~reidchan]
> Redesign single instance pool in CleanerChore
> ---------------------------------------------
>
> Key: HBASE-20095
> URL: https://issues.apache.org/jira/browse/HBASE-20095
> Project: HBase
> Issue Type: Improvement
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Critical
> Attachments: HBASE-20095.master.001.patch,
> HBASE-20095.master.002.patch, HBASE-20095.master.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
