[ 
https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388155#comment-16388155
 ] 

Reid Chan commented on HBASE-20095:
-----------------------------------

The purpose of {{reconfig}} is to avoid updating pool while cleaning is on the 
flight. If chore is working, {{reconfig}} is set true, and updating pool will 
happen after cleaning done, which is {{runCleaner()}}.
{code}
@Override
  protected void chore() {
    if (getEnabled()) {
      if (runCleaner()) {
        LOG.debug("Cleaned all WALs under {}",  oldFileDir);
      } else {
        LOG.warn("WALs outstanding under {}", oldFileDir);
      }
      // After each clean chore, checks if receives reconfigure notification 
while cleaning
      if (POOL.canUpdateImmediately(conf)) {
        POOL.updatePool();
      }
    } else {
      LOG.debug("Cleaner chore disabled! Not cleaning.");
    }
  }
{code}
Hope i make it clear.

> Redesign single instance pool in CleanerChore
> ---------------------------------------------
>
>                 Key: HBASE-20095
>                 URL: https://issues.apache.org/jira/browse/HBASE-20095
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Reid Chan
>            Assignee: Reid Chan
>            Priority: Critical
>         Attachments: HBASE-20095.master.001.patch, 
> HBASE-20095.master.002.patch, HBASE-20095.master.003.patch, 
> HBASE-20095.master.004.patch, HBASE-20095.master.005.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to