[
https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388151#comment-16388151
]
Mike Drob commented on HBASE-20095:
-----------------------------------
{code}
boolean canUpdateImmediately(Configuration conf) {
if (reconfig) { // second one will go into this branch
reconfig = false;
return true;
}
int newSize = calculatePoolSize(conf.get(CHORE_POOL_SIZE,
DEFAULT_CHORE_POOL_SIZE));
if (newSize == size) {
LOG.trace("Size from configuration is same as previous={}, no need to
update.", newSize);
return false;
}
size = newSize; // first one will update size
if (pool.getPoolSize() == 0) {
// Chore does not work now, update it immediately.
return true;
}
// Chore is working, update it after it finished.
reconfig = true; // first one will also set reconfig to true
return false;
}
{code}
> Redesign single instance pool in CleanerChore
> ---------------------------------------------
>
> Key: HBASE-20095
> URL: https://issues.apache.org/jira/browse/HBASE-20095
> Project: HBase
> Issue Type: Improvement
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Critical
> Attachments: HBASE-20095.master.001.patch,
> HBASE-20095.master.002.patch, HBASE-20095.master.003.patch,
> HBASE-20095.master.004.patch, HBASE-20095.master.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
