[
https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385933#comment-16385933
]
Reid Chan commented on HBASE-20095:
-----------------------------------
{quote}
Does this method have to be public?
{code}
public static void initChorePool(Configuration conf)
{code}
{quote}
Ya~, it is called outside of package.
bq. static class members should be upper-case per usual java convention
Fixed
{quote}
could bundle the below up into a small inner class.... so only one volatile,
static reference.
{code}
private static volatile ForkJoinPool pool;
private static volatile int poolSize;
{code}
{quote}
Done, please review those parts. BTW, good comments!
> Redesign single instance pool in CleanerChore
> ---------------------------------------------
>
> Key: HBASE-20095
> URL: https://issues.apache.org/jira/browse/HBASE-20095
> Project: HBase
> Issue Type: Improvement
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Critical
> Attachments: HBASE-20095.master.001.patch,
> HBASE-20095.master.002.patch, HBASE-20095.master.003.patch,
> HBASE-20095.master.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
