[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221238#comment-13221238
]
[email protected] commented on HBASE-5443:
------------------------------------------------------
bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > pom.xml, line 750
bq. > <https://reviews.apache.org/r/4054/diff/1/?file=86002#file86002line750>
bq. >
bq. > Do this instead:
bq. >
bq. > if which cygpath >/dev/null 2>/dev/null; then
bq. > # Windows
bq. > else
bq. > # Not Windows
bq. > fi
Why do we need /dev/null twice?
bq. On 2012-03-02 10:30:06, Benoit Sigoure wrote:
bq. > pom.xml, line 761
bq. > <https://reviews.apache.org/r/4054/diff/1/?file=86002#file86002line761>
bq. >
bq. > Actually you can just remove the whole $IS_WIN business and
everything. Simply fix PROTO_DIR and JAVA_DIR when on Windows before calling
protoc.
How about this? The reason for I_PROTO_DIR is to keep "ls $PROTO_DIR/*.proto"
working.
if which cygpath 2> /dev/null; then
I_PROTO_DIR=$PROTO_DIR
else
I_PROTO_DIR=`cygpath --windows $PROTO_DIR`
JAVA_DIR=`cygpath --windows $JAVA_DIR`
fi
mkdir -p $JAVA_DIR 2> /dev/null
for PROTO_FILE in `ls $PROTO_DIR/*.proto 2> /dev/null`
do
protoc -I$I_PROTO_DIR --java_out=$JAVA_DIR $PROTO_FILE
done
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5552
-----------------------------------------------------------
On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-02 18:54:29)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5443.
bq. https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml bb518b1
bq. src/main/proto/RegionAdmin.proto PRE-CREATION
bq. src/main/proto/RegionClient.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
