[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221181#comment-13221181
]
[email protected] commented on HBASE-5443:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5573
-----------------------------------------------------------
This is a lot better already. One thing this doesn't address that I should've
mentioned in my previous review is that the requests and responses still have a
lot of duplicate data. For example if I "Get" a row that contains 3 KeyValue,
in the response, on the wire, I'll get 3 times the key and 3 times the family.
pom.xml
<https://reviews.apache.org/r/4054/#comment12066>
You didn't take into account my comments on fixing this shell scripting
from the previous iteration.
src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment12069>
So a Get request can only fetch multiple Get from a single Region? That's
not good. We need true multi-get, where you can fetch things from multiple
regions on the same RegionServer at once.
src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment12068>
trailing whitespaces
src/main/proto/RegionClient.proto
<https://reviews.apache.org/r/4054/#comment12070>
I don't know if we should let the client specify the TTL. Right now in
HBase the TTL is hardcoded in the Configuration object of the RegionServer.
Actually I'm fine with allowing clients specify their own TTL as long as we
bound the TTL with the servers' Configuration.
src/main/proto/hbase.proto
<https://reviews.apache.org/r/4054/#comment12071>
I still don't understand how these can be optional.
- Benoit
On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-02 18:54:29)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5443.
bq. https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml bb518b1
bq. src/main/proto/RegionAdmin.proto PRE-CREATION
bq. src/main/proto/RegionClient.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
