[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221218#comment-13221218
]
jirapos...@reviews.apache.org commented on HBASE-5443:
------------------------------------------------------
bq. On 2012-03-02 19:31:46, Jimmy Xiang wrote:
bq. > This is another option for scan. This way, we will have only one scan
method, no need to open/next/close.
bq. >
bq. > Which one do you prefer? In the ScanRequest, either scannerId or scan
must be specified, not both.
bq. >
bq. > message Scan {
bq. > required RegionSpecifier region = 1;
bq. > repeated Column column = 2;
bq. > repeated Attribute attribute = 3;
bq. > optional bytes startRow = 4;
bq. > optional bytes stopRow = 5;
bq. > optional string filterName = 6;
bq. > optional TimeRange timeRange = 7;
bq. > optional uint32 maxVersions = 8 [default = 1];
bq. > optional bool cacheBlocks = 9 [default = true];
bq. > optional uint32 rowsToCache = 10;
bq. > optional uint32 batchSize = 11;
bq. > }
bq. >
bq. > message ScanRequest {
bq. > optional uint64 scannerId = 1;
bq. > optional Scan scan = 2;
bq. > optional uint32 numberOfRows = 3;
bq. > optional bool closeScanner = 4;
bq. > optional uint32 ttl = 5;
bq. > }
bq. >
bq. > message ScanResponse {
bq. > repeated Result result = 1;
bq. > optional uint64 scannerId = 2;
bq. > optional bool moreResults = 3;
bq. > optional uint32 ttl = 4;
bq. > }
bq. >
bq.
bq. Michael Stack wrote:
bq. So we would do away with openScanner, next, and close, just do scan?
Inside in the ScanRequest, we'd carry over the Scan specification each time?
We'd be able to honor the current openScanner, next, close client-facing API
but could add a new scan method to the public api that allowed passing the
above specifications? Sounds good.
The only issue is that both optional. They need to know to specify one. From
documentation?
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5575
-----------------------------------------------------------
On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-02 18:54:29)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5443.
bq. https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml bb518b1
bq. src/main/proto/RegionAdmin.proto PRE-CREATION
bq. src/main/proto/RegionClient.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
