[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221221#comment-13221221
]
[email protected] commented on HBASE-5443:
------------------------------------------------------
bq. On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq. > src/main/proto/RegionClient.proto, line 112
bq. > <https://reviews.apache.org/r/4054/diff/2/?file=87679#file87679line112>
bq. >
bq. > trailing whitespaces
Will remove it.
bq. On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq. > pom.xml, line 764
bq. > <https://reviews.apache.org/r/4054/diff/2/?file=87677#file87677line764>
bq. >
bq. > You didn't take into account my comments on fixing this shell
scripting from the previous iteration.
Sorry. I forgot it. Good idea. I will address it in the next diff.
bq. On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq. > src/main/proto/hbase.proto, line 64
bq. > <https://reviews.apache.org/r/4054/diff/2/?file=87680#file87680line64>
bq. >
bq. > I still don't understand how these can be optional.
Ok, I can make family and qualifier required.
bq. On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq. > src/main/proto/RegionClient.proto, line 147
bq. > <https://reviews.apache.org/r/4054/diff/2/?file=87679#file87679line147>
bq. >
bq. > I don't know if we should let the client specify the TTL. Right now
in HBase the TTL is hardcoded in the Configuration object of the RegionServer.
bq. >
bq. > Actually I'm fine with allowing clients specify their own TTL as
long as we bound the TTL with the servers' Configuration.
I see. I will remove it. We can add it back if server supports it later on.
How about lockRow? Does the server support client specified TTL?
bq. On 2012-03-02 19:16:55, Benoit Sigoure wrote:
bq. > src/main/proto/RegionClient.proto, line 63
bq. > <https://reviews.apache.org/r/4054/diff/2/?file=87679#file87679line63>
bq. >
bq. > So a Get request can only fetch multiple Get from a single Region?
That's not good. We need true multi-get, where you can fetch things from
multiple regions on the same RegionServer at once.
I can move the region to Get. That means each Get need to specify a region, so
it can be duplicated. Another option is to add another message like GetGroup
which has a region and a set of Gets.
One more option is to make region optional in the request, and add an optional
region to Get. The region in GetRequest will be used if there is no region
specified in Get.
What do you think?
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5573
-----------------------------------------------------------
On 2012-03-02 18:54:29, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-02 18:54:29)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5443.
bq. https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml bb518b1
bq. src/main/proto/RegionAdmin.proto PRE-CREATION
bq. src/main/proto/RegionClient.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
