[ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221228#comment-13221228 ]
jirapos...@reviews.apache.org commented on HBASE-5443: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4054/#review5583 ----------------------------------------------------------- src/main/proto/RegionAdmin.proto <https://reviews.apache.org/r/4054/#comment12092> If we are getting rid of "Proto" in the message names, might as well get rid of it here too. src/main/proto/RegionClient.proto <https://reviews.apache.org/r/4054/#comment12094> Here too. src/main/proto/hbase.proto <https://reviews.apache.org/r/4054/#comment12095> Here too. src/main/proto/hbase.proto <https://reviews.apache.org/r/4054/#comment12091> You don't have "option optimize_for = SPEED;" here. - Gregory On 2012-03-02 18:54:29, Jimmy Xiang wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4054/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-03-02 18:54:29) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. This is the first draft of the ProtoBuff HRegionProtocol. The corresponding java vs pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443 bq. bq. Please review. I'd like to move ahead after we get to some agreement. bq. bq. bq. This addresses bug HBASE-5443. bq. https://issues.apache.org/jira/browse/HBASE-5443 bq. bq. bq. Diffs bq. ----- bq. bq. pom.xml bb518b1 bq. src/main/proto/RegionAdmin.proto PRE-CREATION bq. src/main/proto/RegionClient.proto PRE-CREATION bq. src/main/proto/hbase.proto PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/4054/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Jimmy bq. bq. > Add PB-based calls to HRegionInterface > -------------------------------------- > > Key: HBASE-5443 > URL: https://issues.apache.org/jira/browse/HBASE-5443 > Project: HBase > Issue Type: Sub-task > Components: ipc, master, migration, regionserver > Reporter: Todd Lipcon > Assignee: Jimmy Xiang > Fix For: 0.96.0 > > Attachments: region_java-proto-mapping.pdf > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira