ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member 
visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r340859585
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 ##########
 @@ -520,7 +520,7 @@ public HMaster(final Configuration conf)
 
       this.rsFatals = new MemoryBoundedLogMessageBuffer(
           conf.getLong("hbase.master.buffer.for.rs.fatals", 1 * 1024 * 1024));
-      LOG.info("hbase.rootdir=" + getRootDir() +
+      LOG.info("hbase.rootdir=" + getDataRootDir() +
 
 Review comment:
   This is part of
   > Rename `fs` to `dataFs`, `rootDir` as `dataRootDir` so as to distinguish 
from the new `walFs`, `walRootDir` (and make it easier to spot bugs).
   
   I think I see some bugs...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to